From 09ff8eadec09233b905f79579900006fb17dd55f Mon Sep 17 00:00:00 2001 From: Ian Jackson Date: Wed, 5 Nov 2014 14:32:47 +0000 Subject: [PATCH] libxl: CODING_STYLE: Discuss existing style problems Document that: - the existing code is not all confirming yet - code should conform - we will sometimes accept patches with nonconforming elements if they don't make matters worse. Signed-off-by: Ian Jackson Acked-by: Wei Liu Release-Acked-by: Konrad Rzeszutek Wilk --- tools/libxl/CODING_STYLE | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/tools/libxl/CODING_STYLE b/tools/libxl/CODING_STYLE index 9a1d6e0933..f5b58909b3 100644 --- a/tools/libxl/CODING_STYLE +++ b/tools/libxl/CODING_STYLE @@ -2,6 +2,24 @@ LIBXENLIGHT CODING STYLE ======================== +AN APOLOGY AND WARNING +---------------------- + +Much of the code in libxl does not yet follow this coding style +document in every respect. However, new code is expected to conform. + +Patches to improve the style of existing code are welcome. Please +separate these out from functional changes. + +If it is not feasible to conform fully to the style while patching old +code, without doing substantial style reengineering first, we may +accept patches which contain nonconformant elements, provided that +they don't make the coding style problem worse overall. + +In this case, the new code should conform to the prevailing style in +the area being touched. + + MEMORY ALLOCATION ----------------- -- 2.30.2